Skip to content
Snippets Groups Projects
  1. Feb 21, 2022
  2. Feb 16, 2022
    • Rehan, MohammedX's avatar
      ShellPkg: Fix Ping GetTimerPeriod API failure · 8a576733
      Rehan, MohammedX authored
      REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3819
      
      
      
      Ping GetTimerPeriod API returns sometime zero value when
      StallCounter has smaller value than RttTimerTick (divide by zero)
      which results some failure at ping UEFI shell command
      
      Signed-off-by: default avatarMohammedX Rehan <mohammedx.rehan@intel.com>
      Reviewed-by: default avatarZhichao Gao <zhichao.gao@intel.com>
      Reviewed-by: default avatarRay Ni <ray.ni@intel.com>
      8a576733
    • Brijesh Singh's avatar
      OvmfPkg/FvbServicesSmm: use the VmgExitLibNull · c28e376e
      Brijesh Singh authored
      BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3835
      
      
      
      The commit ade62c18 caused a boot failure
      when OVMF is build with SECURE_BOOT/SMM enabled.
      
      This happen because the above commit extended the BaseMemEncryptSevLib.inf
      to include VmgExitLib. The FvbServicesSmm uses the functions provided
      by the MemEncryptSevLib to clear the memory encryption mask from the
      page table. It created a dependency, as shown below
      
      OvmfPkg/FvbServicesSmm.inf
       ---> MemEncryptSevLib                   class
       ---> "OvmfPkg/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf"  instance
       ---> VmgExitLib
       ---> "OvmfPkg/VmgExitLib"    instance
       ---> LocalApicLib                       class
       ---> UefiCpuPkg/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf    instance
       ---> TimerLib                           class
       ---> "OvmfPkg/AcpiTimerLib/DxeAcpiTimerLib.inf"              instance
       ---> PciLib                             class
       ---> "OvmfPkg/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf"     instance
      
      The LocalApicLib provides a constructor, execution of the constructor
      causes an exception. The SEV-ES and SEV-SNP do not support the SMM, so
      skip including the VmgExitLib chain. Use the module override to use the
      VmgExitLibNull to avoid the inclusion of unneeded LocalApicLib dependency
      chain in FvbServicesSmm. We ran similar issue for AmdSevDxe driver,
      see commit 19914edc
      
      After the patch, the dependency look like this:
      
      OvmfPkg/FvbServicesSmm.inf
       ---> MemEncryptSevLib                   class
       ---> "OvmfPkg/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf"  instance
       ---> VmgExitLib
       ---> "UefiCpuPkg/Library/VmgExitLibNull"    instance
      
      Fixes: ade62c18
      Reported-by: default avatarAaron Young <aaron.young@oracle.com>
      Cc: Dann Frazier <dann.frazier@canonical.com>
      Cc: Michael Roth <michael.roth@amd.com>
      Cc: James Bottomley <jejb@linux.ibm.com>
      Cc: Min Xu <min.m.xu@intel.com>
      Cc: Jiewen Yao <jiewen.yao@intel.com>
      Cc: Tom Lendacky <thomas.lendacky@amd.com>
      Cc: Jordan Justen <jordan.l.justen@intel.com>
      Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
      Cc: Erdem Aktas <erdemaktas@google.com>
      Cc: Gerd Hoffmann <kraxel@redhat.com>
      Signed-off-by: default avatarBrijesh Singh <brijesh.singh@amd.com>
      Tested-by: default avatardann frazier <dann.frazier@canonical.com>
      Reviewed-by: default avatarJiewen Yao <jiewen.yao@intel.com>
      c28e376e
  3. Feb 15, 2022
  4. Feb 10, 2022
  5. Feb 07, 2022
  6. Feb 04, 2022
  7. Feb 02, 2022
  8. Feb 01, 2022
  9. Jan 30, 2022
  10. Jan 29, 2022
Loading