- Nov 20, 2021
-
-
Harshavardhana authored
there is a corner case where the new check doesn't work where dataDir has changed, especially when xl.json -> xl.meta healing happens, if some healing is partial this can make certain backend files unreadable. This PR fixes and updates unit-tests
-
Harshavardhana authored
-
Aditya Manthramurthy authored
- service account creation for STS accounts - service account session policy update for STS accounts - refactor svc acc tests and add them for OpenID
-
Klaus Post authored
This can cause old entries to be included (albeit unlikely) in resolution.
-
Krishnan Parthasarathi authored
This unit allows users to limit the maximum number of noncurrent versions of an object. To enable this rule you need the following *ilm.json* ``` cat >> ilm.json <<EOF { "Rules": [ { "ID": "test-max-noncurrent", "Status": "Enabled", "Filter": { "Prefix": "user-uploads/" }, "NoncurrentVersionExpiration": { "MaxNoncurrentVersions": 5 } } ] } EOF mc ilm import myminio/mybucket < ilm.json ```
-
Aditya Manthramurthy authored
- Seems to be improving times for shorter jobs at least. - Remove Go 1.16.x tests for IAM and replication
-
- Nov 19, 2021
-
-
Harshavardhana authored
currently getReplicationConfig() failure incorrectly returns error on unexpected buckets upon upgrade, we should always calculate usage as much as possible.
-
Aditya Manthramurthy authored
Bonus: add extensive tests for svc acc actions by users
-
Harshavardhana authored
additionally count only success operations, truncated incomplete calls don't need to be counted.
-
Harshavardhana authored
listing can fail and it is allowed to be retried, instead of returning right away return an error at the end - heal the rest of the buckets and objects, and when we are retrying skip the buckets that are already marked done by using the tracked buckets. fixes #12972
-
Harshavardhana authored
NAS gateway would persist however with or without etcd as before.
-
Mani authored
-
Harshavardhana authored
- Go might reset the internal http.ResponseWriter() to `nil` after Write() failure if the go-routine has returned, do not flush() such scenarios and avoid spurious flushes() as returning handlers always flush. - fix some racy tests with the console - avoid ticker leaks in certain situations
-
Harshavardhana authored
remove fsSimpleRenameFile implementation for Rename()
-
- Nov 18, 2021
-
-
Aditya Manthramurthy authored
Fixes #13676
-
Harshavardhana authored
-
Klaus Post authored
Existing: ```go type xlMetaV2 struct { Versions []xlMetaV2Version `json:"Versions" msg:"Versions"` } ``` Serialized as regular MessagePack. ```go //msgp:tuple xlMetaV2VersionHeader type xlMetaV2VersionHeader struct { VersionID [16]byte ModTime int64 Type VersionType Flags xlFlags } ``` Serialize as streaming MessagePack, format: ``` int(headerVersion) int(xlmetaVersion) int(nVersions) for each version { binary blob, xlMetaV2VersionHeader, serialized binary blob, xlMetaV2Version, serialized. } ``` xlMetaV2VersionHeader is <= 30 bytes serialized. Deserialized struct can easily be reused and does not contain pointers, so efficient as a slice (single allocation) This allows quickly parsing everything as slices of bytes (no copy). Versions are always *saved* sorted by modTime, newest *first*. No more need to sort on load. * Allows checking if a version exists. * Allows reading single version without unmarshal all. * Allows reading latest version of type without unmarshal all. * Allows reading latest version without unmarshal of all. * Allows checking if the latest is deleteMarker by reading first entry. * Allows adding/updating/deleting a version with only header deserialization. * Reduces allocations on conversion to FileInfo(s).
-
Shireesh Anjal authored
This will help other projects like `health-analyzer` to verify that the struct was indeed populated by the minio server, and is not default-populated during unmarshalling of the JSON. Signed-off-by:
Shireesh Anjal <shireesh@minio.io>
-
- Nov 17, 2021
-
-
Harshavardhana authored
legacy objects in 'xl.json' after upgrade, should have following sequence of events - bucket should have versioning enabled and the object should have been overwritten with another version of an object. this situation was not handled, which would lead to older objects to stay perpetually with "legacy" dataDir, however these objects were readable by all means - there weren't converted to newer format. This PR fixes this situation properly.
-
Harshavardhana authored
-
Ashish Kumar Sinha authored
-
Harshavardhana authored
avoid passing lock context while loading bucket metadata, refactor such that we can de-couple things for subsystem loading.
-
Anis Elleuch authored
Add a new Prometheus metric for bucket replication latency e.g.: minio_bucket_replication_latency_ns{ bucket="testbucket", operation="upload", range="LESS_THAN_1_MiB", server="127.0.0.1:9001", targetArn="arn:minio:replication::45da043c-14f5-4da4-9316-aba5f77bf730:testbucket"} 2.2015663e+07 Co-authored-by:
Klaus Post <klauspost@gmail.com>
-
Harshavardhana authored
container limits would not be properly honored in our current implementation, mem.VirtualMemory() function only reads /proc/meminfo which points to the host system information inside the container.
-
Harshavardhana authored
This feature is useful in situations when console is exposed over multiple intranent or internet entities when users are connecting over local IP v/s going through load balancer. Related console work was merged here https://github.com/minio/console/commit/373bfbfe3f16e6f7d376fb9765a4610d76cf15a2
-
- Nov 16, 2021
-
-
Krishnan Parthasarathi authored
With this change, reduceErrs will group all errors due to context cancelation as the same. e.g, Following are errors due to context cancelation seen from 3 remote disks. Their error values are different but they are all caused due to the same context cancelation. ['Post "http://minio2:9000/minio/storage/data1/v37/statvol?disk-id=101cbc99-f5d2-4a9d-b18b-97e872b3e4a7&volume=mybucket": context canceled', 'Post "http://minio3:9000/minio/storage/data1/v37/statvol?disk-id=7a84474b-a4fd-4b80-8aab-d308a587c280&volume=mybucket": context canceled', 'Post "http://minio4:9000/minio/storage/data1/v37/statvol?disk-id=d60d571a-83c8-487d-9e14-beebc94682d2&volume=mybucket": context canceled']
-
Harshavardhana authored
- remove some duplicated code - reported a bug, separately fixed in #13664 - using strings.ReplaceAll() when needed - using filepath.ToSlash() use when needed - remove all non-Go style comments from the codebase Co-authored-by:
Aditya Manthramurthy <donatello@users.noreply.github.com>
-
- Nov 15, 2021
-
-
Aditya Manthramurthy authored
-
Harshavardhana authored
with SelectRestoreRequest OutputLocation provides additional metadata for the object, this is not preserved due to argument order change.
-
Harshavardhana authored
- add checks such that swapped disks are detected and ignored - never used for normal operations. - implement `unrecognizedDisk` to be ignored with all operations returning `errDiskNotFound`. - also add checks such that we do not load unexpected disks while connecting automatically. - additionally humanize the values when printing the errors. Bonus: fixes handling of non-quorum situations in getLatestFileInfo(), that does not work when 2 drives are down, currently this function would return errors incorrectly.
-
Harshavardhana authored
creating service accounts is implicitly enabled for all users, this PR however adds support to reject creating service accounts, with an explicit "Deny" policy.
-
- Nov 13, 2021
-
-
Harshavardhana authored
-
Harshavardhana authored
-
- Nov 12, 2021
-
-
Aditya Manthramurthy authored
- rename InitStore() to initStore() and fix tests - Use IAMSys.Lock() only when IAMSys struct is being mutated
-
- Nov 11, 2021
-
-
Aditya Manthramurthy authored
-
Harshavardhana authored
-
Harshavardhana authored
-
- Nov 10, 2021
-
-
Klaus Post authored
On first list resume or when specifying a custom markers entries could be missed in rare cases. Do conservative truncation of entries when forwarding. Replaces #13619
-
Shireesh Anjal authored
If a given MinIO config is dynamic (can be changed without restart), ensure that it can be reset also without restart. Signed-off-by:
Shireesh Anjal <shireesh@minio.io>
-
Harshavardhana authored
-